Skip to content

Zero-initialize realm_error_t when converting from Status #7154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

jbreams
Copy link
Contributor

@jbreams jbreams commented Nov 20, 2023

What, How & Why?

Fixes #6925.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

Copy link

coveralls-official bot commented Nov 20, 2023

Pull Request Test Coverage Report for Build jonathan.reams_2938

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 57 unchanged lines in 12 files lost coverage.
  • Overall coverage increased (+0.01%) to 91.679%

Files with Coverage Reduction New Missed Lines %
src/realm/index_string.cpp 1 87.78%
src/realm/sync/noinst/client_impl_base.cpp 1 85.51%
src/realm/array_blobs_big.cpp 2 98.72%
src/realm/array_string.cpp 2 88.0%
test/fuzz_group.cpp 2 54.4%
src/realm/sync/network/network.cpp 3 89.66%
src/realm/util/file.cpp 3 82.2%
src/realm/util/serializer.cpp 3 90.03%
test/test_thread.cpp 3 66.67%
src/realm/bplustree.cpp 7 76.74%
Totals Coverage Status
Change from base Build 1856: 0.01%
Covered Lines: 231346
Relevant Lines: 252344

💛 - Coveralls

@jbreams jbreams requested a review from nicola-cab November 20, 2023 20:44
@jbreams jbreams merged commit 4be34a4 into master Nov 22, 2023
@jbreams jbreams deleted the jbr/fix_status_conversion branch November 22, 2023 19:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C-API] Status objects are not mapped correctly to realm_error
3 participants