Allow deletion of ephemeral objects before commit #7064
Conversation
src/realm/table.cpp
Outdated
| @@ -3385,6 +3385,17 @@ void Table::remove_object(ObjKey key) | |||
| { | |||
| Group* g = get_parent_group(); | |||
|
|
|||
| if (is_asymmetric()) { | |||
| REALM_ASSERT(g); | |||
| auto it = std::find_if(g->m_objects_to_delete.begin(), g->m_objects_to_delete.end(), | |||
There was a problem hiding this comment.
nit: auto& objects_to_delete = g->m_objects_to_delete;
Pull Request Test Coverage Report for Build github_pull_request_280703
💛 - Coveralls |
jedelbo
force-pushed
the
je/delete-asymmetric_object
branch
2 times, most recently
from
8a87283 to
f167bd4
Compare
jedelbo
force-pushed
the
je/delete-asymmetric_object
branch
from
f167bd4 to
8b3028e
Compare
src/realm/db.cpp
Outdated
| for (auto it : transaction.m_objects_to_delete) { | ||
| transaction.get_table(it.table_key)->remove_object(it.obj_key); | ||
| // Checking ttl would go here |
There was a problem hiding this comment.
this would be lazy checking
There was a problem hiding this comment.
But I guess if we ever get this implemented, this would be the place to check which objects were due to be deleted. BTW if we skip recording the time the object was created, we can make this even more efficient. @danieltabacaru should we do that?
There was a problem hiding this comment.
I am not saying it's a bad place to check, it's just that we would be relying on other things being committed. I am not sure if it's the same idea, but we don't really need the object keys, the table keys is enough (we can then clear the tables). we can optimize it further by also skipping storing the table keys by iterating through the tables and clearing the asymmetric ones.
There was a problem hiding this comment.
Of course - the table keys are sufficient. Even better!
src/realm/sync/subscriptions.cpp
Outdated
| sub_sets->get_object_with_primary_key(Mixed{version_id})); | ||
| auto obj = sub_sets->get_object_with_primary_key(Mixed{version_id}); | ||
| if (!obj) { | ||
| throw KeyNotFound("Subscription set not found"); |
There was a problem hiding this comment.
we should include the version_id in the message
src/realm/sync/subscriptions.cpp
Outdated
| std::lock_guard<std::mutex> lk(m_pending_notifications_mutex); | ||
| if (version_id < m_min_outstanding_version) { | ||
| return SubscriptionSet(weak_from_this(), version_id, SubscriptionSet::SupersededTag{}); | ||
| } | ||
| throw; | ||
| throw KeyNotFound("Subscription set not found"); |
What, How & Why?
Likely to fix realm/realm-kotlin#1537
☑️ ToDos
[ ] C-API, if public C++ API changed.