Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-ideal transfer and network fault tests with non-ideal network conditions #7063

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Oct 17, 2023

What, How & Why?

Added script to configure the baas proxy toxics for the tests and added 2 evergreen tests on ubuntu for the toxic configurations. Fixed some of the tests, but there are still some failing tests in each of the runs. These additional failures will be handled in separate tests.

Fixes #6887

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@michael-wb michael-wb self-assigned this Oct 17, 2023
@michael-wb michael-wb linked an issue Oct 17, 2023 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
REQUIRE(user);
REQUIRE(!error);
});
int retry_count = 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to make sure the users can log in (given the network faults) so a test can start? I wonder if we can somehow whitelist these requests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was some of my testing - I'm actually going to revert these changes and approach this differently. e.g., use the direct baas admin port for all HTTP (non-websocket) operations.

Copy link
Collaborator

@danieltabacaru danieltabacaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I hope you ran the new tasks a few times.

@michael-wb
Copy link
Contributor Author

LGTM - I hope you ran the new tasks a few times.

Yeah, I forgot to reconfigure the PR run to include the network tests in this last run. I'll rerun those tests when I post my next set of changes.

@michael-wb michael-wb merged commit 5e9062c into feature/network-faultyness Oct 19, 2023
2 checks passed
@michael-wb michael-wb deleted the mwb/add-proxy-parameters branch October 19, 2023 20:32
michael-wb pushed a commit that referenced this pull request Nov 14, 2023
* Add baas-network-tests nightly task for testing sync client operation with non-ideal network conditions (#6852)

* Added support for starting baas proxy
* Fixed some issues when running the scripts
* minor updates to install_baas.sh
* Updates to scripts to run on evergreen spawn host
* Added total time output to object store tests
* Increased initial ssh connect attempts; renamed proxy to 'baas_proxy'
* Minor updates to help output
* Added baas network test to run bass with the proxy
* Added support for separate baas admin api url value
* Minor port check adjustments
* Removed 'compile' task from network_tests
* Disable development mode by default
* Added baas remote host and network tests instructions doc
* Minor updates to the instructions
* Minor updates to documentation

* Add non-ideal transfer and network fault tests with non-ideal network conditions (#7063)

* Added non-ideal transfer and network fault tests
* Added baas-network-tests to be allowed for PR runs
* Updated changelog
* Updated curl command to be silent
* Updated changelog
* Reverted some changes and added descriptions to config.yml

* Fixed test extra delay

* Added some evergreen script updates from another branch

* Disabled baas network faults tests

* Update flx migration test to enable dev mode

* Fix baas branch for network tests

* add more time to 'too large sync message error handling' test

* Added network faults test and pulled nonideal out of nightly tests until fixes are added
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network faults and test during baas-network-tests task
2 participants