Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core metrics #6990

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Remove core metrics #6990

merged 2 commits into from
Sep 20, 2023

Conversation

ironage
Copy link
Contributor

@ironage ironage commented Sep 20, 2023

The internal core metrics haven't been used in a long time. I'm removing them now, and if they are needed in the future we can look at the git history.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed.

@ironage ironage self-assigned this Sep 20, 2023
@cla-bot cla-bot bot added the cla: yes label Sep 20, 2023
@coveralls-official
Copy link

coveralls-official bot commented Sep 20, 2023

Pull Request Test Coverage Report for Build james.stone_370

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 85 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.003%) to 91.211%

Files with Coverage Reduction New Missed Lines %
test/test_dictionary.cpp 1 99.85%
src/realm/object-store/sync/sync_manager.cpp 2 86.9%
src/realm/parser/generated/query_flex.cpp 2 68.61%
src/realm/query.cpp 2 93.6%
src/realm/sync/network/websocket.cpp 2 75.46%
src/realm/table_view.cpp 2 93.91%
src/realm/query_expression.hpp 3 93.51%
src/realm/sync/noinst/protocol_codec.hpp 3 76.56%
src/realm/sync/transform.cpp 3 61.71%
src/realm/util/file_mapper.hpp 3 93.18%
Totals Coverage Status
Change from base Build 1692: 0.003%
Covered Lines: 232434
Relevant Lines: 254832

💛 - Coveralls

Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it's always nice to remove unused code and our code coverage went up a tiny bit :)

@ironage ironage merged commit 95f4a7c into master Sep 20, 2023
@ironage ironage deleted the js/remove-metrics branch September 20, 2023 22:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants