Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle badchangeset error when printing changeset contents in debug #6921

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

michael-wb
Copy link
Contributor

@michael-wb michael-wb commented Aug 23, 2023

What, How & Why?

After the updates from the unify core error handling project, the realm-sync-tests were crashing due to an "unknown instruction type" if debug level trace or higher was enabled. This was due to an exception being thrown by parse_changeset() during the Sync_BadChangeset test, which intentionally creates a bad changeset.

Updated debug output handling to catch the BadChangesetError exception and print a message instead of passing this exception up.

Also, fixed the race condition in the Sync_DetectSchemaMismatch_* tests that was resulting in the realm::TableNameInUse: The specified table name is already in use error. This was due to the first session completing sync before the write transaction transaction on the second session was completed. Moved the call to nonsync_transact_nofity() until after both write transactions were completed.

Also, updated the ssh connection timeout to 60 secs for scp and ssh operations when starting remote baas, since the startup of the remote baas was sometimes failing out. This was likely due to the original connection timeout of 10 seconds.

☑️ ToDos

  • 📝 Changelog update
  • [ ] 🚦 Tests (or not relevant)
  • [ ] C-API, if public C++ API changed.

@danieltabacaru
Copy link
Collaborator

What's with the evergreen failures?

@michael-wb michael-wb requested a review from ironage August 24, 2023 17:28
Copy link
Contributor

@ironage ironage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@michael-wb michael-wb merged commit 32dc53b into master Aug 25, 2023
@michael-wb michael-wb deleted the mwb/fix-test-sync-badchangeset branch August 25, 2023 03:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants