Update list of server app errors and fix assertion failure if unknown app error string is received #6772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
An unhandled app json error response from the server was causing an assertion failure when an error occurred in an atlas function was called. Unfortunately, the specific error value that was causing the failure was not captured in the customer issue.
Updated the error codes list to support the full list of errors that could be thrown by the server (from baas/common/errors.go, although the GraphQL errors were not included) and the
AppUtils::check_for_errors()
function was updated to properly handle error codes that were missing a string -> value mapping in theErrorCodes
class without causing the assertion to fail.NOTE: The numeric values for these app errors was updated to fall within the 5000-6000 range, since the previous range was 4300-4399 and there are more than 100 error values. (potential breaking change)
If an unknown error string from the server is encountered, an AppError will be created with
AppUnknownError
and the reason string will be updated with the error string.Fixes #6758
☑️ ToDos