Update event loop to keep full stack trace if no observer is used #6410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbreams
approved these changes
Mar 22, 2023
| @@ -872,6 +882,8 @@ struct CBindingThreadObserver : public realm::BindingCallbackThreadObserver { | |||
| protected: | |||
| CBindingThreadObserver() = default; | |||
|
|
|||
| const realm_free_userdata_func_t m_empty_free_userdata = [](realm_userdata_t) {}; | |||
There was a problem hiding this comment.
nit: this could be static
danieltabacaru
approved these changes
Mar 23, 2023
added 5 commits
March 23, 2023 12:33
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
One of the side effects of the event loop changes in Platform Networking is that a full stack trace is not observed if an exception occurs on the event loop. Updated the event loop to not use a
try ... catchblock if an event loop callback observer is not being used or thehandle_error()callback is not defined. Also updated the observer class to provide a function that indicates whether or not ahandle_error()callback is provided.☑️ ToDos