Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync client cleanup #4384

Closed
wants to merge 7 commits into from
Closed

Sync client cleanup #4384

wants to merge 7 commits into from

Conversation

finnschiermer
Copy link
Contributor

@finnschiermer finnschiermer commented Feb 3, 2021 •
edited
Loading

This PR

  • removes the ChangesetCooker from the sync client
  • removes the ClientFileAccessCache from the sync client
  • shares a DB object with the App, instead of having a dedicated DB object just for the sync client.
  • adds corresponding shared ownership of Sync ClientReplication object.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)

@finnschiermer finnschiermer force-pushed the fsa/sync-with-shared-db branch from 02cfa34 to 5768d16 Compare February 3, 2021 13:49
@finnschiermer finnschiermer self-assigned this Feb 8, 2021
@ironage ironage linked an issue Feb 9, 2021 that may be closed by this pull request
Remove the ChangesetCooker infrastructure #3952
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 3, 2021
Closed
@tgoyne tgoyne mentioned this pull request Aug 5, 2021
Merged
@bmunkholm bmunkholm marked this pull request as draft November 16, 2021 09:31
@bmunkholm
Copy link
Contributor

@finnschiermer What should happen with this PR? Anything that @RedBeard0531 can use for his current sync cleanup?
I've converted to a "draft" until this get's picked up again. But feel free to close it out if it's no longer relevant.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2024
@tgoyne tgoyne deleted the fsa/sync-with-shared-db branch May 29, 2024 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonask simonask Awaiting requested review from simonask

Assignees

@finnschiermer finnschiermer

Labels
T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the ChangesetCooker infrastructure
2 participants
@finnschiermer @bmunkholm