Add Dockerfile #3455
Merged
Add Dockerfile #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides: - a runtime environment on ubuntu that does not include the Swift toolchain. - supportintg `docker build https://github.com/realm/SwiftLint.git` - add `libcurl4-openssl-dev` as build time dependency that introduced by #3058
Hiding dependencies required at build time in the Dockerfile
|
Might need a CI to build Dockerfile? |
Yes I think that'd be worthwhile, would've caught the change from #3058 |
jpsim
approved these changes
Dec 4, 2020
|
Is there any particular reason not to migrate from Azure Pipelines to GitHub Actions? |
|
Migrating to GitHub Actions is in my list of things to do, I just haven’t gotten around to it yet. |
|
We can add a CI job in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker build https://github.com/realm/SwiftLint.gitlibcurl4-openssl-devas build time dependency that introduced by Add remote, parent & child configuration features #3058MakefiletoDockerfile.