Empty count configuration #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
lordzsolt
force-pushed
the
empty-count-configuration
branch
3 times, most recently
from
5da9770
to
31f6624
Compare
marcelofabri
reviewed
Feb 8, 2020
| } | ||
|
|
||
| public struct EmptyCountConfiguration: RuleConfiguration, Equatable { | ||
| private(set) var severityConfiguration = SeverityConfiguration(.warning) |
There was a problem hiding this comment.
the existing default is error, can you change it to keep the same behavior?
There was a problem hiding this comment.
Updated.
Sorry, I didn't notice it was .error before
lordzsolt
force-pushed
the
empty-count-configuration
branch
from
31f6624
to
15dbf2e
Compare
|
Thanks! Great first contribution! 🎉 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an improvement for #827
It adds a a configuration option, to ignore variables named
count. This option is disabled by default.