Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for NestingRule #1340

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Conversation

sora0077
Copy link
Contributor

@sora0077 sora0077 commented Mar 3, 2017

Implements #1318

@SwiftLintBot
Copy link

SwiftLintBot commented Mar 3, 2017

12 Messages
📖 Linting WordPress-iOS with this PR took 16.84s vs 17.0s on master (0% faster)
📖 Linting swift with this PR took 15.92s vs 15.32s on master (3% slower)
📖 Linting Aerial with this PR took 0.55s vs 0.56s on master (1% faster)
📖 Linting SourceKitten with this PR took 1.7s vs 1.62s on master (4% slower)
📖 Linting Sourcery with this PR took 3.75s vs 3.54s on master (5% slower)
📖 Linting ios-oss with this PR took 23.52s vs 22.36s on master (5% slower)
📖 Linting Alamofire with this PR took 4.44s vs 4.61s on master (3% faster)
📖 Linting firefox-ios with this PR took 25.39s vs 24.06s on master (5% slower)
📖 Linting Nimble with this PR took 2.65s vs 2.44s on master (8% slower)
📖 Linting Quick with this PR took 0.78s vs 0.76s on master (2% slower)
📖 Linting realm-cocoa with this PR took 4.05s vs 3.89s on master (4% slower)
📖 Linting Moya with this PR took 0.57s vs 0.55s on master (3% slower)

Generated by 🚫 danger

@codecov-io
Copy link

codecov-io commented Mar 3, 2017

Codecov Report

Merging #1340 into master will decrease coverage by -0.02%.
The diff coverage is 82.6%.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.02%     
==========================================
  Files         170      171       +1     
  Lines        8660     8720      +60     
==========================================
+ Hits         7096     7144      +48     
- Misses       1564     1576      +12
Impacted Files Coverage Δ
Source/SwiftLintFramework/Rules/NestingRule.swift 100% <100%> (ø)
...ules/RuleConfigurations/NestingConfiguration.swift 77.77% <77.77%> (ø)
...iftLintFrameworkTests/RuleConfigurationTests.swift 77.27% <81.81%> (+0.59%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a964167...a8faa31. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented Mar 10, 2017

Excellent work! 👏

@jpsim jpsim merged commit 1e0e84e into realm:master Mar 10, 2017
@sora0077 sora0077 deleted the nesting-configuration branch March 11, 2017 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants