-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to generate rules documentation #1107
Conversation
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 87.96% 87.25% -0.71%
==========================================
Files 197 198 +1
Lines 9761 9840 +79
==========================================
Hits 8586 8586
- Misses 1175 1254 +79
Continue to review full report at Codecov.
|
It would also be good if this generated a Table of Contents for the top of the Markdown file. As we keep adding rules, this is going to be become one loooooong file. |
We probably should use Sourcery for this instead |
Actually, that won't work 😅 |
🚢 |
Oh my, I'm reviewing this now finally and this is soooo cool. This is a very nice addition to the project. I'm very happy you did this. I was expecting to have more nitpicks, but really I just have #1660. |
🎉 I hope we can inprove this even more in the future with rule configurations and better descriptions for rules 🙌 |
Will fix #1078
This produces a markdown looking like this.
Next steps:
Makefile
to run this command and output it to a file.RuleConfiguration
protocol to provide more information about the parameters.detailedDescription: String?
onRuleDescription
that would be used to generate this. All descriptions currently were thought for console and Xcode usage and we should go into more details in the docs. @jpsim did an awesome job on the 0.14 release blog post that could be used as an inspiration.