Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Mark rule does not allow marks with only a hyphen #778

Closed
aron opened this issue Aug 25, 2016 · 5 comments · Fixed by #789
Closed

New Mark rule does not allow marks with only a hyphen #778

aron opened this issue Aug 25, 2016 · 5 comments · Fixed by #789
Labels
bug Unexpected and reproducible misbehavior.

Comments

@aron
Copy link

aron commented Aug 25, 2016

The mark rule added in #768 does not allow marks containing only a hyphen.

// MARK: -

We use these often to split up files into sections as they insert dividers in the Document Items view.
@jpsim jpsim added the bug Unexpected and reproducible misbehavior. label Aug 25, 2016
@jpsim
Copy link
Collaborator

jpsim commented Aug 25, 2016

Thanks for reporting this. Should be an easy fix, if you're looking to contribute to SwiftLint @aron 😄

roddi added a commit to roddi/SwiftLint that referenced this issue Aug 30, 2016
@roddi
fix Mark rule case // MARK: -
c9e09e4 
see realm#778
@roddi roddi mentioned this issue Aug 30, 2016
Merged
@roddi
Copy link
Contributor

roddi commented Aug 30, 2016

please accept my pull request for this issue: #789

@otaran
Copy link

otaran commented Dec 1, 2016

This bug is reproducible in 0.13.1/cc @jpsim

@jpsim jpsim reopened this Dec 1, 2016
@jpsim
Copy link
Collaborator

jpsim commented Dec 1, 2016

You're right, sorry about reintroducing this. I'm on it.

jpsim added a commit that referenced this issue Dec 1, 2016
@jpsim
fix #778
fc2e887
@jpsim jpsim mentioned this issue Dec 1, 2016
Merged
@jpsim jpsim closed this as completed in #914 Dec 1, 2016
jpsim added a commit that referenced this issue Dec 1, 2016
@jpsim
Merge branch 'master' into swift3.0
b238438 
* master:
  optimize MarkRule.violationRangesInFile() a tiny bit
  fix missing variable rename
  fix #778
@otaran
Copy link

otaran commented Dec 1, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected and reproducible misbehavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix Mark rule case // MARK: - roddi/SwiftLint
4 participants
@aron @roddi @jpsim @otaran