Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Request] Tuple Pattern Rule #2203

Closed
2 tasks done
marcelofabri opened this issue May 11, 2018 · 0 comments · Fixed by #3086
Closed
2 tasks done

[Rule Request] Tuple Pattern Rule #2203

marcelofabri opened this issue May 11, 2018 · 0 comments · Fixed by #3086
Labels
rule-request Requests for a new rules.

Comments

@marcelofabri
Copy link
Collaborator

New Issue Checklist

Rule Request

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.

From Google's Swift Style Guide:

Assigning variables through a tuple pattern (sometimes referred to as a tuple shuffle) is only permitted if the left-hand side of the assignment is unlabeled.

Labels on the left-hand side closely resemble type annotations, and can lead to confusing code.

  1. Provide several examples of what would and wouldn't trigger violations.
// ok
let (a, b) = (y: 4, x: 5.0)

// triggers
let (x: a, y: b) = (y: 4, x: 5.0)
let (x: Int, y: Double) = (y: 4, x: 5.0)
  1. Should the rule be configurable, if so what parameters should be configurable?

Just severity.

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a
    rule as opt-in.

Probably enabled by default, depends on oss-check.

@marcelofabri marcelofabri added the rule-request Requests for a new rules. label May 11, 2018
marcelofabri added a commit that referenced this issue Feb 8, 2020
marcelofabri added a commit that referenced this issue Feb 8, 2020
marcelofabri added a commit that referenced this issue Feb 8, 2020
* Add `tuple_pattern` opt-in rule

Fixes #2203

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule-request Requests for a new rules.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant