Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach NestingRule to ignore types declared in functions #1151

Closed
jpsim opened this issue Jan 10, 2017 · 1 comment · Fixed by #1645
Closed

Teach NestingRule to ignore types declared in functions #1151

jpsim opened this issue Jan 10, 2017 · 1 comment · Fixed by #1645
Labels
enhancement Ideas for improvements of existing features and rules. wontfix Issues that became stale and were auto-closed by a bot.

Comments

@jpsim
Copy link
Collaborator

jpsim commented Jan 10, 2017

The idea behind types in the nesting rule is to not have a complex interface, but that doesn't apply to types scoped within a single function, such as this example:https://github.com/jpsim/SourceKitten/blob/0.16.0/Source/SourceKittenFramework/SourceDeclaration.swift#L74
@jpsim jpsim added the enhancement Ideas for improvements of existing features and rules. label Jan 10, 2017
@marcelofabri marcelofabri mentioned this issue Jun 2, 2017
Closed
Skoti added a commit to Skoti/SwiftLint that referenced this issue Jun 26, 2017
@Skoti
Separated nesting level counting for types and functions in nesting…
9a2cdb0 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
@Skoti Skoti mentioned this issue Jun 26, 2017
Merged
Skoti added a commit to Skoti/SwiftLint that referenced this issue Jul 26, 2017
@Skoti
Separated nesting level counting for types and functions in nesting…
11dd989 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Aug 26, 2017
@Skoti
Separated nesting level counting for types and functions in nesting…
4e97146 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Sep 11, 2017
@Skoti
Separated nesting level counting for types and functions in nesting…
25bb7e0 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Oct 22, 2017
@Skoti
Separated nesting level counting for types and functions in nesting…
68b6885 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue May 10, 2018
@Skoti
Separated nesting level counting for types and functions in nesting…
116fc5d 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Feb 4, 2019
@Skoti
Separated nesting level counting for types and functions in nesting…
dbc6d91 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Feb 4, 2019
@Skoti
Separated nesting level counting for types and functions in nesting…
373e0ee 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Feb 4, 2019
@Skoti
Separated nesting level counting for types and functions in nesting…
de63410 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Skoti added a commit to Skoti/SwiftLint that referenced this issue Feb 11, 2019
@Skoti
Separated nesting level counting for types and functions in nesting…
6d4673c 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
@stale
Copy link

stale bot commented Nov 8, 2020

This issue has been automatically marked as stale because it has not had any recent activity. Please comment to prevent this issue from being closed. Thank you for your contributions!

@stale stale bot added the wontfix Issues that became stale and were auto-closed by a bot. label Nov 8, 2020
Skoti added a commit to Skoti/SwiftLint that referenced this issue Nov 9, 2020
@Skoti
Separated nesting level counting for types and functions in nesting…
4fc58d0 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
jpsim pushed a commit to Skoti/SwiftLint that referenced this issue Nov 9, 2020
@Skoti @jpsim
Separated nesting level counting for types and functions in nesting…
b984159 
… rule (fixes realm#1151). Enhanced `nesting` rule to search for nested types and functions within closures and statements. Enhanced `nesting` rule to allow for one nested type within a function even if breaking a maximum type level nesting (fixes realm#1151).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Ideas for improvements of existing features and rules. wontfix Issues that became stale and were auto-closed by a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separating level counting for types and functions in nesting rule. Skoti/SwiftLint
1 participant
@jpsim