style: merge some sass theme sources #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* theme_breadcrumbs into theme_layout * theme_mathjax into theme * font_awesome_compatibility into theme * font_local into theme
|
Having separation between these files is fine I think, I don't think there is strong reason to remove this separation right now. At very least, I'd rather that |
agjohnson
added
Needed: design decision
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the one hand, the comment about
bowerintheme.sassis outdated. On the other hand, there are four files which are 5-50 lines each (~125 all together). These are merged intotheme.sassand_theme_layout.sass.