Skip to content

Docs: Remove outdated and misleading Poetry guide #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Docs: Remove outdated and misleading Poetry guide #9794

merged 2 commits into from
Dec 13, 2022

Conversation

juantocamidokura
Copy link
Contributor

@juantocamidokura juantocamidokura commented Dec 9, 2022

Fixes #9771


📚 Documentation previews 📚

@benjaoming
Copy link
Contributor

Thanks!

You'll need to also remove the reference in docs/user/guides/developers.rst

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ericholscher
Copy link
Member

ericholscher commented Dec 13, 2022

We should likely update this page with some pointers, or at least put in a redirect to some content that we have around this. It's a common topic, so where should we be sending people who need this type of content?

@benjaoming
Copy link
Contributor

@ericholscher how about we do a redirect to the configuration example? https://docs.readthedocs.io/en/stable/build-customization.html#install-dependencies-with-poetry (secondary question: are redirects with anchors supported?)

@benjaoming
Copy link
Contributor

@ericholscher in case you agree that we can do this without a placeholder, the redirect is ready 👍

@ericholscher
Copy link
Member

That redirect works 👍

@ericholscher ericholscher merged commit 940a1b7 into readthedocs:main Dec 13, 2022
@juantocamidokura juantocamidokura deleted the remove_missleading_poetry_doc_page branch December 13, 2022 16:17
@benjaoming
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing documentation when using Poetry with ReadTheDocs
3 participants