Fix jinja2 pinning on Sphinx 1.8 feature flagged projects#9036
Merged
Fix jinja2 pinning on Sphinx 1.8 feature flagged projects#9036
Conversation
Sphinx 3.1.0 breaks Sphinx 1.8.6 projects, so we want to avoid another major issue like with docutils breakage in the past.
ericholscher
changed the title
agjohnson
reviewed
Mar 24, 2022
agjohnson
approved these changes
Mar 24, 2022
humitos
approved these changes
Mar 28, 2022
Member
humitos
left a comment
humitos
left a comment
There was a problem hiding this comment.
Looks good to fix the immediate problem. I'd like to not have these cases hardcoded here, but I know they are needed, unfortunately.
| def setup_base(self): | ||
| conda_env_path = os.path.join(self.project.doc_path, 'conda') | ||
| version_path = os.path.join(conda_env_path, self.version.slug) | ||
| os.path.join(conda_env_path, self.version.slug) |
Member
There was a problem hiding this comment.
This line seems can be completely removed because we are not assigning it to any variable.
Contributor
|
This has been hotfix for bit, so I'm going to merge this as-is. I want to avoid having a hotfix PR half-applied in multiple releases. We can treat follow up clean up and fixing tests as a separate issue, as we won't be hotfixing test fix or cleanup commits |
humitos
added a commit
that referenced
this pull request
Nov 23, 2022
Initial file to start documenting hosting integrations. Related #9036 Related readthedocs/meta#71 Related readthedocs/meta#35
humitos
added a commit
that referenced
this pull request
Nov 23, 2022
Initial file to start documenting hosting integrations. Related #9036 Related readthedocs/meta#71 Related readthedocs/meta#35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.