Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom URLConf redirects #7155

Merged
merged 5 commits into from
Jun 8, 2020
Merged

Fix custom URLConf redirects #7155

merged 5 commits into from
Jun 8, 2020

Conversation

ericholscher
Copy link
Member

This fixes our automatic redirects to work properly.

@ericholscher ericholscher requested review from agjohnson and a team June 4, 2020 16:23
@ericholscher ericholscher changed the title Only set default values when they're in the URLConf Fix custom URLConf redirects Jun 5, 2020
agjohnson
agjohnson approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Including @humitos for review as I'm not the best to comment on proxito.

@agjohnson agjohnson requested a review from humitos June 5, 2020 18:42
humitos
humitos approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. I'm not super familiarized with the custom URLconf, tho :)

@ericholscher ericholscher merged commit 853f473 into master Jun 8, 2020
@ericholscher ericholscher deleted the redirect-urlconf-properly branch June 8, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @agjohnson