Proxito middleware: reset to original urlconf after request #7137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also fixes a flaky test. We hit this before after proxito too https://github.com/readthedocs/readthedocs.org/blob/8ebded69160f495c56e2966da90bad3be2dc9f5f/readthedocs/core/middleware.py#L132-L136
|
Ok... it doesn't fail on my computer anymore, but it still fails on travis 🙃 |
humitos
reviewed
May 28, 2020
Comment on lines
+203
to
+204
| # Reset URLconf for this thread | ||
| # to the original one. |
There was a problem hiding this comment.
why not put the comment in just one line? 😄
There was a problem hiding this comment.
I just like short lines to have more space in my monitor 🤷♂️
|
@stsewd yea, the original test works for me locally, but fails on travis. Really not sure what's going on, but the request-based URLConf stuff is definitely buggy. |
|
@ericholscher tests should be passing now, to replicate locally I had to run the tests a lot of times till I got an error, then trying with/without my fix several times to see if failed or not... |
ericholscher
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a flaky test.
We hit this before proxito too
readthedocs.org/readthedocs/core/middleware.py
Lines 132 to 136 in 8ebded6