Do not override the domain of Azure Storage #6928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we are not proxying the Storage request via NGINX anymore, all the internal communication between containers should be done using the containers host (e.g. `storage:10000`). This is required for example by the Embed API that hits the storage from the web container, which does not work anymore hitting `community.dev.readthedocs.io` since we removed the NGINX proxy rule.
humitos
requested review from
ericholscher and
a team
and removed request for
ericholscher
ericholscher
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are not proxying the Storage request via NGINX anymore, all the internal
communication between containers should be done using the containers
host (e.g.
storage:10000).This is required for example by the Embed API that hits the storage from the web
container, which does not work anymore hitting
community.dev.readthedocs.iosince we removed the NGINX proxy rule.