Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the status name in CI configurable via setting #6877

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Make the status name in CI configurable via setting #6877

merged 2 commits into from
Apr 8, 2020

Conversation

ericholscher
Copy link
Member

We had the same one on .org/.com and it was overwriting each other.

@ericholscher
Make the status name in CI configurable via setting
00ea459 
We had the same one on .org/.com and it was overwriting each other.
@ericholscher ericholscher requested a review from a team April 7, 2020 23:14
stsewd
stsewd approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed from the constants now

readthedocs.org/readthedocs/builds/constants.py

Line 103 in f128166

RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'

@ericholscher
Copy link
Member Author

Ah yea, I had that locally but didn't push it up 👍

@ericholscher ericholscher merged commit 5759379 into master Apr 8, 2020
@ericholscher ericholscher deleted the configurable-status-name branch April 8, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericholscher @humitos @stsewd