Add more exceptions as WARNING log level #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RepositoryError` and `ProjectConfigurationError` are user errors that we should not log as ERROR, but as WARNING instead. Also, the `throws` list is removed here since all these exceptions happen inside the Build Environment who already manage them in the `__exit__` method and so, they are never seen by the task.
stsewd
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RepositoryErrorandProjectConfigurationErrorare user errors thatwe should not log as ERROR, but as WARNING instead.
Also, the
throwslist is removed here since all these exceptionshappen inside the Build Environment who already manage them in the
__exit__method and so, they are never seen by the task.