Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly proxy the Proxito headers via nginx/sendfile #6782

Merged
merged 6 commits into from
Mar 14, 2020
Merged

Properly proxy the Proxito headers via nginx/sendfile #6782

merged 6 commits into from
Mar 14, 2020

Conversation

ericholscher
Copy link
Member

This is a hack, but it works.

humitos
humitos approved these changes Mar 14, 2020
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with these changes. Finally we will have more headers in our responses.

I'm just not sure about the 404 handler, though.

dockerfiles/nginx/proxito.conf Outdated Show resolved Hide resolved
@ericholscher ericholscher merged commit bbd844e into master Mar 14, 2020
@ericholscher ericholscher deleted the fix-proxito-headers branch March 14, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos