Add TOS PDF output #6739
Merged
Add TOS PDF output #6739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, RTD doesn't support this output because it's a secondary file. You have to generate this file locally, and you have to also disable `-W` option, as there are warnings that fail the build, unrelated to this change.
We can add a comment about this above the latex documents config, or we can even create a new Makefile entry to generate only this file that already include the |
humitos
approved these changes
Mar 4, 2020
|
We could certainly add support for building/syncing these files, but linking them directly from our dashboard is a bit tricky, but I'd be 👍 with building in basic support for it at least. |
ericholscher
added a commit
that referenced
this pull request
Mar 9, 2020
Revert "Merge pull request #6739 from readthedocs/agj/docs-tos-pdf"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, RTD doesn't support this output because it's a secondary
file. You have to generate this file locally, and you have to also
disable
-Woption, as there are warnings that fail the build,unrelated to this change.