Only output debug logging from RTD app #6717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In normal settings only log INFO and above, but in dev we should log DEBUG to console. This should only output RTD debug messages though, because others are only logging INFO and above via the logger.
humitos
reviewed
Feb 28, 2020
Comment on lines
623
to
+624
| # Always send from the root, handlers can filter levels | ||
| 'level': 'DEBUG', | ||
| 'level': 'INFO', |
There was a problem hiding this comment.
If the root logger filters by INFO, can we set DEBUG level in the handler later? With this change, is DEBUG logging under debug.log file still working?
There was a problem hiding this comment.
We want to be able to log DEBUG messages, but only from our application. So we want DEBUG to be output, but only sent via the RTD app, not all libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In normal settings only log INFO and above,
but in dev we should log DEBUG to console.
This should only output RTD debug messages though,
because others are only logging INFO and above via the logger.