Be explicit on privacy level for search tests

readthedocs/search/tests/conftest.py

@@ -6,7 +6,8 @@
 from django.core.management import call_command
 from django_dynamic_fixture import G
 
-from readthedocs.projects.models import Project, HTMLFile
+from readthedocs.projects.constants import PUBLIC
+from readthedocs.projects.models import HTMLFile, Project
 from readthedocs.search.documents import PageDocument
 from readthedocs.sphinx_domains.models import SphinxDomain
 
@@ -27,7 +28,14 @@ def all_projects(es_index, mock_processed_json, db, settings):
     settings.ELASTICSEARCH_DSL_AUTOSYNC = True
     projects_list = []
     for project_slug in ALL_PROJECTS:
-        project = G(Project, slug=project_slug, name=project_slug)
+        project = G(
+            Project,
+            slug=project_slug,
+            name=project_slug,
+            main_language_project=None,
+            privacy_level=PUBLIC,
+        )
+        project.versions.update(privacy_level=PUBLIC)
 
         for file_basename in PROJECT_DATA_FILES[project.slug]:
             # file_basename in config are without extension so add html extension

readthedocs/search/tests/test_api.py

@@ -5,6 +5,7 @@
 from django_dynamic_fixture import G
 
 from readthedocs.builds.models import Version
+from readthedocs.projects.constants import PUBLIC
 from readthedocs.projects.models import HTMLFile, Project
 from readthedocs.search.documents import PageDocument
 from readthedocs.search.tests.utils import (
@@ -139,7 +140,12 @@ def test_doc_search_filter_by_version(self, api_client, project):
         query = get_search_query_from_project_file(project_slug=project.slug)
         latest_version = project.versions.all()[0]
         # Create another version
-        dummy_version = G(Version, project=project, active=True)
+        dummy_version = G(
+            Version,
+            project=project,
+            active=True,
+            privacy_level=PUBLIC,
+        )
         # Create HTMLFile same as the latest version
         latest_version_files = HTMLFile.objects.all().filter(version=latest_version)
         for f in latest_version_files:

readthedocs/search/tests/test_faceted_search.py

@@ -5,7 +5,7 @@
 
 @pytest.mark.django_db
 @pytest.mark.search
-class TestPageSearch(object):
+class TestPageSearch:
 
     @pytest.mark.parametrize('case', ['upper', 'lower', 'title'])
     def test_search_exact_match(self, client, project, case):

readthedocs/search/tests/test_views.py

@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import re
 
 import pytest
@@ -10,8 +8,8 @@
 from readthedocs.builds.models import Version
 from readthedocs.projects.models import HTMLFile, Project
 from readthedocs.search.tests.utils import (
-    get_search_query_from_project_file,
     DATA_TYPES_VALUES,
+    get_search_query_from_project_file,
 )
 
 
@@ -85,7 +83,7 @@ def test_search_project_filter_language(self, client, project):
 
 @pytest.mark.django_db
 @pytest.mark.search
-class TestPageSearch(object):
+class TestPageSearch:
     url = reverse('search')
 
     def _get_search_result(self, url, client, search_params):