Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docker settings to fix local environment #6703

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 25, 2020

Use a different names for Docker Compose settings after #6623 that creates a new directory called proxito/ under settings.

/readthedocs/settings/build_docker.py
/readthedocs/settings/celery_docker.py
/readthedocs/settings/proxito_docker.py
/readthedocs/settings/web_docker.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't need / at the start?

Suggested change
/readthedocs/settings/web_docker.py
readthedocs/settings/web_docker.py

Copy link
Contributor

@davidfischer davidfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixed the development issues I had around those changes.

@humitos humitos merged commit f5e6c1f into master Feb 25, 2020
@humitos humitos deleted the humitos/settings-local-environment branch February 25, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants