Add feature flag to just completely skip sync and symlink operations #6689
Conversation
We can control this on a per-project basis. Once we remove symlinking and Syncers, this can go away entirely.
|
I'm not confident I protected all of the sync/symlink calls. I didn't put the same logic in the actual tasks as we shouldn't fire off thousands of tasks that are effectively noop tasks. This did save the webs from being hammered with thousands of symlink tasks for the project however. |
agjohnson
added
the
PR: work in progress
|
This worked for me in my testing to stop symlinking versions for specific projects. This didn't protect the |
| @@ -1505,6 +1505,7 @@ def add_features(sender, **kwargs): | |||
| UPDATE_CONDA_STARTUP = 'update_conda_startup' | |||
| CONDA_APPEND_CORE_REQUIREMENTS = 'conda_append_core_requirements' | |||
| ALL_VERSIONS_IN_HTML_CONTEXT = 'all_versions_in_html_context' | |||
| SKIP_SYNC = 'skip_sync' | |||
There was a problem hiding this comment.
nit: I would call it SKYP_WEB_SERVERS_SYNC to make it explicit.
|
I don't think it worth the effort, but we could enable this Feature flag automatically on |
agjohnson
removed
the
PR: work in progress
Revert "Add feature flag to just completely skip sync and symlink operations (#6689)"
We can control this on a per-project basis. Once we remove symlinking
and Syncers, this can go away entirely.