Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azurite --loose option #6669

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Add azurite --loose option #6669

merged 1 commit into from
Feb 24, 2020

Conversation

agjohnson
Copy link
Contributor

I was getting 5xx errors from azurite every other load of a static asset
file. I found this issue and added a fix that was mentioned:
Azure/Azurite#337

I can not reccomend this fix and I did not try to spend any time
understanding Azurite.

I was getting 5xx errors from azurite every other load of a static asset
file. I found this issue and added a fix that was mentioned:
Azure/Azurite#337

I can not reccomend this fix and I did not try to spend any time
understanding Azurite.
@agjohnson agjohnson added the Needed: replication Bug replication is required label Feb 17, 2020
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may hit this issue because we are not pinning azurite image (just using latest). My image is from 5 months ago. They may changed something.

We may be sending an invalid HTTP header when proxying to it. --loose mode just disable the strict check on headers, which does not really affects us. So, I suppose we should be fine with this.

After updating my azurite docker image and using this PR, I still have timeout/500 issues:

web_1        | x-ms-client-request-id:fac68bee-5235-11ea-b9d8-02420a0a0007
web_1        | x-ms-date:Tue, 18 Feb 2020 10:04:31 GMT
web_1        | x-ms-range:bytes=0-33554431
web_1        | x-ms-version:2018-03-28
web_1        | /devstoreaccount1/devstoreaccount1/static/staticfiles.json
web_1        | timeout:20
web_1        | [18/Feb/2020 10:04:31] urllib3.connectionpool:266[20]: DEBUG Resetting dropped connection: storage
web_1        | [18/Feb/2020 10:04:31] urllib3.connectionpool:437[20]: DEBUG http://storage:10000 "GET /devstoreaccount1/static/staticfiles.json?timeout=20 HTTP/1.1" 500 0

We may need to take a deeper look at this.

@agjohnson
Copy link
Contributor Author

Also, to clarify, the --loose option did resolve the problem I was seeing. I'm able to consistently reload the assets now. I'd be fine pinning the Azurite image or adding the --loose option. I don't think it makes a whole lot of sense to spend time figuring out Azurite as we don't use it anywhere outside local development.

@humitos
Copy link
Member

humitos commented Feb 20, 2020

What's the hash of your azurite image?

@humitos
Copy link
Member

humitos commented Feb 20, 2020

I re-downloaded the azurite docker image and it works now 🤷‍♂️

@humitos humitos merged commit 5586e9c into master Feb 24, 2020
@humitos humitos deleted the agj/azureite-5xx-fix branch February 24, 2020 11:06
@agjohnson
Copy link
Contributor Author

My azurite is:

mcr.microsoft.com/azure-storage/azurite         latest              741b0142b740        10 days ago         292MB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: replication Bug replication is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants