Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception when we get an InfiniteRedirect #6609

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Raise exception when we get an InfiniteRedirect #6609

merged 3 commits into from
Jan 29, 2020

Conversation

ericholscher
Copy link
Member

No description provided.

humitos
humitos approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

It would be good to add a test later for this case of raising InfiniteRedirect and get a custom 404 page rendered.

@ericholscher ericholscher merged commit 3481c80 into master Jan 29, 2020
@ericholscher ericholscher deleted the handle-infinite-redirect-404 branch January 29, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos