Use our standard auth mixin for proxito downloads #6572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same logic as in the Proxito views, it just extends it to the downloads.
readthedocs/projects/views/public.py
Outdated
| if not self.allowed_user(request, final_project, version_slug): | ||
| return self.get_unauthed_response(request, final_project) | ||
|
|
||
| version = final_project.versions.public(user=request.user).filter(slug=version_slug).first() |
There was a problem hiding this comment.
Don't we need to raise a 404 here if version is None?
There was a problem hiding this comment.
True -- I will re-add that logic.
davidfischer
approved these changes
Jan 23, 2020
agjohnson
approved these changes
Jan 23, 2020
agjohnson
pushed a commit
that referenced
this pull request
Jan 23, 2020
* Use our standard auth mixin for proxito downloads This is the same logic as in the Proxito views, it just extends it to the downloads. * re-add 404 logic * Add a bit of janky hacks * Remove functions to remove hacky isinstance * Fix lint
humitos
reviewed
Jan 28, 2020
Comment on lines
+121
to
+122
| def allowed_user(self, *args, **kwargs): | ||
| return True |
There was a problem hiding this comment.
My idea was to default this to False to avoid mistakes if it's not overwritten in the class that inherit from this. Forcing the class that inherit from this to re-define it.
There was a problem hiding this comment.
Yea, this worried me a bit, we should fix it in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same logic as in the Proxito views,
it just extends it to the downloads.