Use django storage to build URL returned by El Proxito #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Dec 17, 2019
This allows us to have more control on the storage class (return always True on `.exists()`) and only mock the class when we need a different behavior.
|
I brought some other commits from the other PR that fixes the tests in a good way by using a custom storage backend for tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Isolate fixes from 6c2b187#diff-fd3394188d8793947a3ccbb4924994a1R99
With this change, we pass the full URL back to NGINX who will proxy it as is to the storage.
This fixes currently 404 in production for test-builds documentation for all versions.