added previous year gsoc projects #6333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Oct 28, 2019
docs/gsoc.rst
Outdated
|
|
||
| * Search Improvement (2018) (https://summerofcode.withgoogle.com/archive/2018/projects/4656335308193792/) | ||
| * Improved Search And Search As You Type (2019) (https://summerofcode.withgoogle.com/archive/2019/projects/6376055881859072/) | ||
|
|
dojutsu-user
suggested changes
Oct 29, 2019
docs/gsoc.rst
Outdated
| @@ -184,6 +184,15 @@ which provide outlines on the larger tasks that we're hoping to accomplish. | |||
| .. _these issues: https://github.com/readthedocs/readthedocs.org/issues?direction=desc&labels=Feature&page=1&sort=updated&state=open | |||
| .. _milestones: https://github.com/readthedocs/readthedocs.org/milestones | |||
|
|
|||
| Some previous year project selected in Google Summer Of Code | |||
There was a problem hiding this comment.
I think the heading can be improved to something like: Previous Years Projects.
Currently, Some suggests that some projects are not listed.
docs/gsoc.rst
Outdated
| @@ -184,6 +184,15 @@ which provide outlines on the larger tasks that we're hoping to accomplish. | |||
| .. _these issues: https://github.com/readthedocs/readthedocs.org/issues?direction=desc&labels=Feature&page=1&sort=updated&state=open | |||
| .. _milestones: https://github.com/readthedocs/readthedocs.org/milestones | |||
|
|
|||
| Some previous year project selected in Google Summer Of Code | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
I think this should be a separate sub-section. So It should be ---------- instead of ~~~~~~.
You can read more about this here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections
docs/gsoc.rst
Outdated
Comment on lines
190
to
193
| * Search Improvement (2018) (https://summerofcode.withgoogle.com/archive/2018/projects/4656335308193792/) | ||
| * Improved Search And Search As You Type (2019) (https://summerofcode.withgoogle.com/archive/2019/projects/6376055881859072/) | ||
|
|
||
| * Building Docs For Pull Requests(2019) (https://summerofcode.withgoogle.com/archive/2019/projects/6239099793440768/) |
There was a problem hiding this comment.
Issue description describes to link the blog posts published in blog.readthedocs.com and not the GSoC links. It should be something like this:
stsewd
reviewed
Oct 29, 2019
docs/gsoc.rst
Outdated
|
|
||
| * `Search Improvement (2018) <https://summerofcode.withgoogle.com/archive/2018/projects/4656335308193792/>`_ | ||
| * `Improved Search And Search As You Type (2019) <https://summerofcode.withgoogle.com/archive/2019/projects/6376055881859072/>`_ | ||
|
|
Co-Authored-By: Santos Gallegos <[email protected]>
stsewd
reviewed
Oct 30, 2019
docs/gsoc.rst
Outdated
| @@ -184,6 +184,14 @@ which provide outlines on the larger tasks that we're hoping to accomplish. | |||
| .. _these issues: https://github.com/readthedocs/readthedocs.org/issues?direction=desc&labels=Feature&page=1&sort=updated&state=open | |||
| .. _milestones: https://github.com/readthedocs/readthedocs.org/milestones | |||
|
|
|||
| Projects from previous years | |||
| ------------------ | |||
There was a problem hiding this comment.
The length of the - should be the same as the title, that's the reason Travis is failing
dojutsu-user
suggested changes
Oct 30, 2019
docs/gsoc.rst
Outdated
Comment on lines
190
to
193
| * `Improved Search And Search As You Type (2019) <https://summerofcode.withgoogle.com/archive/2019/projects/6376055881859072/>`_ | ||
|
|
||
| * `Building Docs For Pull Requests(2019) <https://summerofcode.withgoogle.com/archive/2019/projects/6239099793440768/>`_ | ||
| * `Search Improvement (2018) <https://summerofcode.withgoogle.com/archive/2018/projects/4656335308193792/>`_ |
There was a problem hiding this comment.
Links should be of blog.readthedocs.com.
dojutsu-user
suggested changes
Oct 31, 2019
docs/gsoc.rst
Outdated
Comment on lines
190
to
193
| * `Improved Search And Search As You Type (2019) <https://blog.readthedocs.com/search-improvements/>`_ | ||
| * `Building Docs For Pull Requests(2019) <https://blog.readthedocs.com/building-docs-for-pull-requests/>`_ | ||
| * `Search Improvement (2018) <https://blog.readthedocs.com/improved-search-and-search-as-you-type/>`_ | ||
|
|
There was a problem hiding this comment.
Links for Improved Search And Search As You Type and Search Improvement are wrong.
Co-Authored-By: Vaibhav Gupta <[email protected]>
dojutsu-user
suggested changes
Oct 31, 2019
docs/gsoc.rst
Outdated
Comment on lines
190
to
193
| * `Improved Search And Search As You Type (2019) <https://blog.readthedocs.com/search-improvements/>`_ | ||
| * `Building Docs For Pull Requests (2019) <https://blog.readthedocs.com/building-docs-for-pull-requests/>`_ | ||
| * `Search Improvement (2018) <https://blog.readthedocs.com/improved-search-and-search-as-you-type/>`_ | ||
|
|
There was a problem hiding this comment.
Links are not correct.
Correct links are as follows:
- Improved Search And Search As You Type (2019) - https://blog.readthedocs.com/improved-search-and-search-as-you-type/
- Building Docs For Pull Requests (2019) - https://blog.readthedocs.com/building-docs-for-pull-requests/
- Search Improvement (2018) - https://blog.readthedocs.com/search-improvements/
There was a problem hiding this comment.
oh, yes. The link for search improvements and search as you type are swapped
There was a problem hiding this comment.
i have updated the given issue
dojutsu-user
approved these changes
Oct 31, 2019
humitos
reviewed
Nov 1, 2019
|
|
||
| * `Improved Search And Search As You Type (2019) <https://blog.readthedocs.com/improved-search-and-search-as-you-type/>`_ | ||
| * `Building Docs For Pull Requests (2019) <https://blog.readthedocs.com/building-docs-for-pull-requests/>`_ | ||
| * `Search Improvement (2018) <https://blog.readthedocs.com/search-improvements/>`_ |
There was a problem hiding this comment.
Aren't we missing Config file V2 here? https://blog.readthedocs.com/configuration-file-v2/
There was a problem hiding this comment.
It wasn't officially a GSoC project, so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6156
Added previous year gsoc project to the gsoc.rst file