Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a RC1 image with Python 3.8 #6327

Closed
wants to merge 1 commit into from

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 24, 2019

This PR add support to start testing a RC1 Docker image with support for 3.8.

Related #6324 readthedocs/readthedocs-docker-images#111

@humitos humitos changed the title Add support for a RC1 Docker image with support for Python 3.8 Add support for a RC1 Docker image with Python 3.8 Oct 24, 2019
@humitos humitos changed the title Add support for a RC1 Docker image with Python 3.8 Add support for a RC1 image with Python 3.8 Oct 24, 2019
@humitos
Copy link
Member Author

humitos commented Oct 24, 2019

I just realized that it's better if we only upload the image to build servers and change container_image from the admin instead of allowing a "temporal" image in our config file. I'm closing this.

@humitos humitos closed this Oct 24, 2019
@humitos humitos deleted the humitos/python-3.8 branch October 24, 2019 11:46
@humitos
Copy link
Member Author

humitos commented Oct 24, 2019

Hrm... I'm not sure what's the pattern we can follow here to support a testing image where we can select the Python interpreter. I think we don't have one for this already.

I'm thinking that it could be a feature flag to force python3.8 as the interpreter for a specific project. So, we will need to set this flag + project.container_image = 'readthedocs/build:6.0rc1'

@stsewd
Copy link
Member

stsewd commented Oct 24, 2019

We shouldn't change the python interpreter to people that have a specific version. Putting the image on the to 6.0rc1 should be enough, so people using python: 3 get the highest version, 3.8 for this image.

But I think we need to change the code to override the one from the config file, currently the docker image is being overridden in a later step.

@stsewd
Copy link
Member

stsewd commented Oct 24, 2019

But I think we need to change the code to override the one from the config file, currently the docker image is being overridden in a later step.

Nope, I got confused with the USE_TESTING_BUILD_IMAGE (wich actually is allways overriden by the config file, the config always have a build.image attribute).

if self.config and self.config.build.image:
self.container_image = self.config.build.image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants