Store version media availability #6278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stored during the build process - Does a particular version have a PDF? ePub? etc.
humitos
approved these changes
Oct 14, 2019
| @@ -90,6 +90,9 @@ class Meta: | |||
| 'built', | |||
| 'downloads', | |||
| 'type', | |||
| 'has_pdf', | |||
| 'has_epub', | |||
| 'has_htmlzip', | |||
There was a problem hiding this comment.
shouldn't we add these to fields to APIv3 Version detail endpoint as well?
I'm not sure, since the download link will appear only if it exists. So, maybe it's redundant.
There was a problem hiding this comment.
These has_* fields feel like redundant fields for our API
There was a problem hiding this comment.
I agree it is a little awkward. These fields are used for writing by the build servers but not reading by the general public.
ericholscher
approved these changes
Oct 14, 2019
Co-Authored-By: Manuel Kaufmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the availability of particular download media to be saved on the version at the end of the build process. For example, does a particular version have a PDF? ePub? etc.
Currently, we rely on the presence of a file existing at a certain filesystem path to determine whether media/downloads are available. As we move toward storage being an abstraction on top of the filesystem where it is possibly remote (eg. Cloud storage) we don't want to have to query remote storage to know whether a version has a PDF.
This PR is the first step in changing that. The next is to write a job which calculates
has_pdf/has_epub/has_htmlzipfor the latest build of every version. Lastly, we can actually use the fields stored in the DB instead of checking the filesystem.