Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #6269

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Fix tests #6269

merged 2 commits into from
Oct 10, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Oct 10, 2019

This is required to fix the tests on .com

Each commit has the why for each change.

@stsewd
Use request factory mixin
b10c8b8 
Some parts of the code still depend
of some minimal middlewares.
@stsewd
Use https explicitly
e4c0c07
@stsewd stsewd requested a review from a team October 10, 2019 01:30
ericholscher
ericholscher approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand this, but seems reasonable. We should probably lint for this if we can, to stop it from happening in the future.

@ericholscher ericholscher merged commit 2bd2dac into master Oct 10, 2019
@ericholscher ericholscher deleted the stsewd/fix-tests branch October 10, 2019 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher