Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inactive version list not showing when no resuts returned #6264

Merged
merged 2 commits into from
Oct 9, 2019
Merged

Fix inactive version list not showing when no resuts returned #6264

merged 2 commits into from
Oct 9, 2019

Conversation

ericholscher
Copy link
Member

Previously it would hide the UI when users search
for a term with no matching versions

@ericholscher
Fix inactive version list not showing when no resuts returned
9a13eb2 
Previously it would hide the UI when users search
for a term with no matching versions
humitos
humitos approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change makes sense.

We may want to add an {% empty %} block as well saying that there is no versions matching the filter/search.

@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Oct 9, 2019
@humitos humitos merged commit 6a0a2c2 into master Oct 9, 2019
@humitos humitos deleted the fix-inactive-version-list-not-showing branch October 9, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @humitos