Remove .cache directory when CLEAN_AFTER_BUILD feature is enabled #6236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hrm, there is a pytest issue when running the tests. |
dojutsu-user
reviewed
Oct 2, 2019
|
Another solution would be disabling caching if the setting is set. |
You are right.
I think this is wiser and we should do this instead of using caching for things that we are going to remove immediately. If we ever want this cache, we should probably use a local PyPI mirror (or devpi) which would probably save a lot more space that what we are doing currently and speed things up. |
|
Closed in favor of #6239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disk space is growing up without limit in
build04.We do have a solution for this by
CLEAN_AFTER_BUILDfeature/setting, but it does not remove.cachenorartifacts.This PR add
.cacheas a directory to be removed as well.artifactsis not possible to remove just yet because how the pull sync system works (webs need to pull these files from the builders before it removes them)