Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the force when fetching with Git #6109

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Use the force when fetching with Git #6109

merged 2 commits into from
Aug 27, 2019

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 27, 2019

I am not familiar enough with the internals here to grasp the full extend of using The Force ™️ here, so please consider this carefully. Thanks.

xref #6097

stsewd
stsewd approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this solution 👍

@saadmk11 said it works, right?

@stsewd stsewd requested review from saadmk11 and a team August 27, 2019 16:01
saadmk11
saadmk11 approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@saadmk11 saadmk11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried it locally. It works fine on my side . Thank you for your Pull Request. :)

ericholscher
ericholscher approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I'll add a comment about why this is here, also 👍

@ericholscher ericholscher merged commit b9aff0c into readthedocs:master Aug 27, 2019
@pllim pllim deleted the patch-1 branch August 28, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@stsewd stsewd stsewd approved these changes

@saadmk11 saadmk11 saadmk11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pllim @ericholscher @stsewd @saadmk11