IPv6 in X-Forwarded-For fix #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Aug 9, 2019
dojutsu-user
approved these changes
Aug 9, 2019
| # only client's ip is present | ||
| request = RequestFactory().get('/') | ||
| request.META['HTTP_X_FORWARDED_FOR'] = '203.0.113.195' | ||
| client_ip = get_client_ip(request) | ||
| self.assertEqual(client_ip, '203.0.113.195') | ||
|
|
||
| # only client's ip is present | ||
| request = RequestFactory().get('/') | ||
| ip = '2001:abc:def:012:345:6789:abcd:ef12' |
There was a problem hiding this comment.
Where did you get the sample ip?
There was a problem hiding this comment.
I just created it. You can always test if it's a valid IP (it is) with the ipaddress module.
|
Hotfixed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me whether our production proxies would ever include an IPv6 with port. In the errors I'm seeing in prod, I don't see that. X-Forwarded-For is not exactly a standard so there isn't something to look up here.