Handle .x in version sorting

[davidfischer]

• Handle .x in version sorting (eg. 1.0.x or 2.x). A few projects use this in their branch names like Pallets and Django.
• Added tests for version sorting

Fixes: #6010

[humitos]

This solution is good to me. It does not affect anything that it's already working 👍

[humitos]

I know that this is not a behavior that you changed, but I'd like to sort alphanumeric versions from A to Z instead at some point. Feels more human-readable when you have a many of these.

[davidfischer]

Do we have any examples of projects that use something like this? I can think of Ubuntu off the top of my head, but that's about it.

[humitos]

test-builds, which may not apply as a real project but shows the sorting problem when building alphanumeric branch names

[davidfischer]

A side comment that isn't exactly related to this PR is that the sort_versions() function ignores "uncomparable" versions like "latest" and "stable". This is by design it seems but perhaps a comment is warranted. This wasn't immediately clear to be before testing it out. Thoughts on adding a comment?

readthedocs.org/readthedocs/projects/version_handling.py

Lines 76 to 101 in a370ade

	def sort_versions(version_list):
	"""
	Take a list of Version models and return a sorted list.
	:param version_list: list of Version models
	:type version_list: list(readthedocs.builds.models.Version)
	:returns: sorted list in descending order (latest version first) of versions
	:rtype: list(tupe(readthedocs.builds.models.Version,
	packaging.version.Version))
	"""
	versions = []
	for version_obj in version_list:
	version_slug = version_obj.verbose_name
	comparable_version = parse_version_failsafe(version_slug)
	if comparable_version:
	versions.append((version_obj, comparable_version))
	return list(
	sorted(
	versions,
	key=lambda version_info: version_info[1],
	reverse=True,
	),
	)

[humitos]

This is by design it seems but perhaps a comment is warranted. This wasn't immediately clear to be before testing it out. Thoughts on adding a comment?

I'm 👍 adding a comment explaining this where you consider necessary.

[davidfischer]

I added the comments explaining comparable versions. This is ready to merge, I believe.

[ericholscher]

Good change.

[ericholscher]

I wish this was present in the upstream, but that's a fight for another day :)