Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append core requirements to Conda environment file #5956

Merged
merged 4 commits into from
Jul 23, 2019

Commits on Jul 18, 2019

  1. Append core requirements to Conda environment file

    We run 3 steps when a project depends on conda.
    
    1. create the whole environment based on user's YAML file
    2. run `conda install` with our own dependencies
    3. run `pip install` with some of our dependencies that are not
    published on conda repositories.
    
    This commit changes this to make it in just one step (at environment
    creation). To do this, it appends our own requirements to the
    `environment.yml` file under `dependencies` and `dependencies.pip`
    config (see https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html#create-env-file-manually)
    
    It also shows the resulting `environment.yml` in the build output.
    
    This behavior is added behind a feature flag so we can test it first.
    
    This allow users to be able to pin their dependencies as they want
    without us upgrading them in the second step. Also, this should
    improve the build time, since dependencies resolution is done just
    once.
    
    Related to
    
    * #3829
    * #5631
    humitos committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    c9edb04 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7834a3d View commit details
    Browse the repository at this point in the history
  3. Lint fixed

    humitos committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    f8bf8ba View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. Configuration menu
    Copy the full SHA
    4f815e3 View commit details
    Browse the repository at this point in the history