Properly return None when there's no highlight on a hit.

[ericholscher]

No description provided.

[dojutsu-user]

This also needs to change --

readthedocs.org/readthedocs/search/views.py

Lines 120 to 134 in 0f47f05

	sorted_results = [
	{
	'type': hit._nested.field,
	# here _source term is not used because
	# django gives error if the names of the
	# variables start with underscore
	'source': hit._source.to_dict(),
	'highlight': utils._remove_newlines_from_dict(
	hit.highlight.to_dict()
	),
	}
	for hit in sorted(all_results, key=attrgetter('_score'), reverse=True)
	]

I think we should move _get_inner_hits_highlights to search.utils and then use it from there?

[dojutsu-user]

I think it would be better to move the entire logic of sorting the search results to search.utils and call from there.

[dojutsu-user]

@ericholscher
I have opened PR #5950

[ericholscher]

Great, I'm going to merge this since it's already hotfixed, and then we can update that branch to not conflict 👍