Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix count value of docsearch REST api #5926

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Fix count value of docsearch REST api #5926

merged 1 commit into from
Jul 15, 2019

Conversation

dojutsu-user
Copy link
Member

Related: #5235

This method works in local but I am not sure that whether this is correct way or not.

ericholscher
ericholscher approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I would like to eventually refactor the entire way we're doing the API, since I think tricking Django into thinking the ES object is a queryset is not a great solution in the long run. This is a good fix for now though.

@ericholscher ericholscher merged commit 7e112c1 into readthedocs:master Jul 15, 2019
@dojutsu-user dojutsu-user deleted the results-total-hack branch July 15, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dojutsu-user @ericholscher