Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove django guardian from querysets #5853

Merged
merged 2 commits into from
Jun 27, 2019
Merged

Remove django guardian from querysets #5853

merged 2 commits into from
Jun 27, 2019

Commits on Jun 26, 2019

  1. Remove django guardian from querysets 

    We set these permissions when we save a project or a version

https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/projects/models.py#L424-L425
https://github.com/rtfd/readthedocs.org/blob/1ee57dec16f352d14ca17c1bcd8877a9a88a8f0a/readthedocs/builds/models.py#L249-L250

We set them to all the owners of a project,
we already know all projects of an user with `user.projects`.

For now I'm just removing guardian from the querysets,
in another PR I'm going to remove the dep of guardian
    @stsewd
    stsewd committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    fdc90fc View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2019

  1. Bring back .distinct()

    @stsewd
    stsewd committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    78291f9 View commit details
    Browse the repository at this point in the history