-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanent redirect feature added #5727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these changes. They allow us to give a custom solution for a particular request without breaking anything and not exposing users with a dangerous redirect.
Users can request a 301 redirect via our support queue and we just need to make a change on those redirects after they set them up and are happy.
I'm requesting for another review from the @rtfd/core team to be sure that this is the first step to support this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think we could expose this to users over time, but modeling it is the first step 👍
Should we add a migration to change all the existing 301 redirects to 302? |
@davidfischer this PR has a migration to change all existing 301 redirects to 302 |
Ahhh, I missed that part of the migration. I saw that there was one migration and I assumed it was auto-generated. However, I now see that changing the default and setting all the ones in the DB is in one migration. Thanks. |
I want to make the redirects and all future redirects in my project 301. I sent an email and no positive response yet. When can we get the option to to do this ourselves? |
@w3guy Hi! I sent you an email yesterday with a question and today I made your redirects 301. Please, keep talking over email. There is no need to comment on a closed PR to ask for support 😃 Thanks! |
closes #5104