"Default branch: latest" does not exist Fix. #5547
Conversation
readthedocs/projects/forms.py
Outdated
| @@ -246,7 +246,7 @@ def __init__(self, *args, **kwargs): | |||
| # the special cases of LATEST and STABLE. | |||
| all_versions_choices = [ | |||
| (v.commit_name, v.verbose_name) | |||
There was a problem hiding this comment.
We can use verbose_name for the id too now (commit_name was used only for the special cases of latest and stable). Also, we should add a test when the user has a version named latest or stable. Using commit_name will make the test fail.
Something like 82944ca
There was a problem hiding this comment.
Okay I'll Update the PR accordingly. 👍
There was a problem hiding this comment.
@stsewd What did you actually mean by this can you please clarify?
Using commit_name will make the test fail.
There was a problem hiding this comment.
If you write a test with a tag named latest or stable the current implementation will fail.
There was a problem hiding this comment.
I mean, a version created by the user machine=False
There was a problem hiding this comment.
@stsewd Updated the changes. but I'm Not sure I correctly understood what you meant about the tests. please have a look and let me know.
| privacy_level=PUBLIC, | ||
| identifier='ab96cbff71a8f40a4240aaf9d12e6c10', | ||
| verbose_name='stable', | ||
| ) |
There was a problem hiding this comment.
Creating a version named stable is a specific test, we shouldn't merge it with the rest.
There was a problem hiding this comment.
@stsewd Okay 👍 . Updated the PR
|
@stsewd Thanks for helping me. It was a Great Experience :) |
closes #5390