Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to in-progress build from dashboard. #5431

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

shivanshu1234
Copy link
Contributor

Ref: #5427

Please let me know if I have made any mistake.
Thank You.

Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a note on the message

<p>
{% blocktrans trimmed %}
You'll be able to view your documentation in a minute or two,
once your project is done building.
For more information about the build,
click <a href="{{ latest_build_url }}">here.</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just put the link in the above text Your documentation is building

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that sounds better. I've made the change.

@stale
Copy link

stale bot commented May 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 13, 2019
@stsewd stsewd removed the Status: stale Issue will be considered inactive soon label May 13, 2019
@stsewd stsewd requested a review from a team May 13, 2019 15:59
@stsewd stsewd requested a review from a team May 13, 2019 16:51
@ericholscher ericholscher merged commit 10e0352 into readthedocs:master Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants