Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove view docs dropdown #5400

Merged
merged 5 commits into from
Mar 6, 2019
Merged

Remove view docs dropdown #5400

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c15a76
Remove the dropdown next to "View Docs"
ericholscher Mar 5, 2019
9a36ae9
More places
ericholscher Mar 5, 2019
d9ee036
Use a right arrow to unbreak styles
ericholscher Mar 5, 2019
99191eb
Remove arrows
stsewd Mar 5, 2019
5a1e667
Fix ifelse
stsewd Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions readthedocs/templates/core/project_list_detailed.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,24 +29,15 @@
<span class="right-menu quiet">{% trans "No builds" %}</span>
{% endif %}

{% if project.has_good_build %}
<span class="dropdown" style="position:absolute; right:0px; top:0px;">
<span>
<a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
<a href="#">&#x25BC;</a>
</span>
<ul>
<li><input type="search" placeholder="{% trans "Search" %}&hellip;" /></li>
{% for version in project.ordered_active_versions reversed %}
<li><a href="{{ version.get_absolute_url }}">{{ version.slug }}</a></li>
{% endfor %}
</ul>
</span>
{% else %}
<ul class="module-item-menu">
<li><a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a></li>
<li>
{% if project.has_good_build %}
<a href="{{ project.get_docs_url }}">{% trans "View Docs" %}
{% else %}
<a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: else and endif indentation is wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it was missing a </a> :/

</li>
</ul>
{% endif %}


</li>
Expand Down
23 changes: 7 additions & 16 deletions readthedocs/templates/core/project_list_featured.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,15 @@
<a href="{{ user.get_absolute_url }}" class="quiet">({{ user }})</a>
{% endfor %}

{% if project.has_good_build %}
<span class="dropdown" style="position:absolute; right:0px; top:0px;">
<span>
<a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
<a href="#">&#x25BC;</a>
</span>
<ul>
<li><input type="search" placeholder="{% trans "Search" %}&hellip;" /></li>
{% for version in project.ordered_active_versions reversed %}
<li><a href="{{ version.get_absolute_url }}">{{ version.slug }}</a></li>
{% endfor %}
</ul>
</span>
{% else %}
<ul class="module-item-menu">
<li><a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a></li>
<li>
{% if project.has_good_build %}
<a href="{{ project.get_docs_url }}">{% trans "View Docs" %}</a>
{% else %}
<a href="{{ project.get_builds_url }}">{% trans "No Docs" %}</a>
{% endif %}
</li>
</ul>
{% endif %}

</li>

Expand Down